fix: get_account now works if called a second time for the same accou…

…nt name
algorandfoundation · Mar 23, 2023 · 513dd4c · 513dd4c · github-actions · Mar 23, 2023
1 parent 706df1a
commit 513dd4c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/algokit_utils/account.py b/src/algokit_utils/account.py
@@ -128,7 +128,7 @@ def get_account(
 
     if is_sandbox(client):
         account = get_or_create_kmd_wallet_account(client, name, fund_with, kmd_client)
-        os.environ[mnemonic_key] = account.private_key
+        os.environ[mnemonic_key] = from_private_key(account.private_key)  # type: ignore[no-untyped-call]
         return account
 
     raise Exception(f"Missing environment variable '{mnemonic_key}' when looking for account '{name}'")
diff --git a/tests/test_account.py b/tests/test_account.py
@@ -0,0 +1,11 @@
+from algokit_utils import get_account
+from algosdk.v2client.algod import AlgodClient
+from conftest import get_unique_name
+
+
+def test_account_can_be_called_twice(algod_client: AlgodClient) -> None:
+    account_name = get_unique_name()
+    account1 = get_account(algod_client, account_name)
+    account2 = get_account(algod_client, account_name)
+
+    assert account1 == account2
File	Stmts	Miss	Cover	Missing
src/algokit_utils
account.py	77	8	90%	42–45, 78, 90, 115, 134
app.py	156	15	90%	109, 143, 147–148, 223, 227, 233–241, 252–255
application_client.py	558	128	77%	154, 169, 193, 198, 216, 218, 222, 235, 254, 257, 259, 261, 438, 482–484, 664–674, 733, 753, 801–802, 807, 822, 846–857, 872, 896–907, 920, 940–949, 953–954, 962–966, 972–996, 1017, 1048–1055, 1075, 1107, 1112, 1118, 1153–1159, 1163–1168, 1170, 1229, 1262, 1268, 1296–1301, 1317, 1322–1332, 1338, 1344, 1351–1354, 1389–1392, 1397–1402, 1406–1428, 1436, 1460
application_specification.py	89	25	72%	75, 78–87, 100, 108, 116, 158, 174, 196–205, 209
logic_error.py	35	7	80%	28, 60, 66–70
network_clients.py	47	3	94%	61, 64–65
TOTAL	999	186	81%