chore: remove warning when update unmounted component

alibaba · Aug 23, 2021 · afb049a · afb049a
1 parent fab69e2
commit afb049a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 128 deletions.
diff --git a/packages/rax/src/__tests__/asyncUpdate.js b/packages/rax/src/__tests__/asyncUpdate.js
diff --git a/packages/rax/src/vdom/updater.js b/packages/rax/src/vdom/updater.js
@@ -106,18 +106,6 @@ function requestUpdate(component, partialState, callback) {
   let internal = component[INTERNAL];
 
   if (!internal) {
-    if (process.env.NODE_ENV !== 'production') {
-      // Block other render
-      Host.__isUpdating = false;
-      console.error(
-        "Warning: Can't perform a Rax state update on an unmounted component. This " +
-          'is a no-op, but it indicates a memory leak in your application. To ' +
-          'fix, cancel all subscriptions and asynchronous tasks in %s.',
-        component.__isReactiveComponent
-          ? 'a useEffect cleanup function'
-          : 'the componentWillUnmount method',
-      );
-    }
     return;
   }
 

diff --git a/scripts/bench/src/index.js b/scripts/bench/src/index.js
@@ -49,7 +49,7 @@ async function runBench(framework, benchmarks, local, skipBuild) {
     try {
       const benchmarkOptions = {
         port: config.PORT.toFixed(),
-        headless: args.headless,
+        headless: args.headless || true,
         chromeBinaryPath: args.chromeBinary,
         numIterationsForAllBenchmarks: config.REPEAT_RUN,
         numIterationsForStartupBenchmark: config.REPEAT_RUN_STARTUP