Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config initialization #175

Merged

Conversation

louyuting
Copy link
Collaborator

@louyuting louyuting commented Jun 25, 2020

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

The wiki: https://github.com/alibaba/sentinel-golang/wiki/通用配置项
had been updated.

@louyuting louyuting requested a review from sczyh30 June 25, 2020 04:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.23%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   44.25%   44.02%   -0.24%     
==========================================
  Files          76       76              
  Lines        4142     4164      +22     
==========================================
  Hits         1833     1833              
- Misses       2104     2126      +22     
  Partials      205      205              
Impacted Files Coverage Δ
api/init.go 0.00% <0.00%> (ø)
core/log/metric/aggregator.go 29.16% <0.00%> (ø)
core/config/entity.go 46.87% <14.28%> (-4.85%) ⬇️
core/config/config.go 23.46% <33.33%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bd5dc...bb961c8. Read the comment docs.

@louyuting louyuting force-pushed the 2020-06-20-refine-specification-for-config branch from 7221209 to e83e6a4 Compare June 25, 2020 04:36
@louyuting
Copy link
Collaborator Author

The travis seems to have stopped working.
@sczyh30

@louyuting louyuting added area/configuration Issue related to configurations of Sentinel to-review PRs to review labels Jun 25, 2020
core/config/entity.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2020

CLA assistant check
All committers have signed the CLA.

@louyuting louyuting force-pushed the 2020-06-20-refine-specification-for-config branch from 5b93c09 to bb961c8 Compare June 28, 2020 15:02
@louyuting louyuting requested a review from sczyh30 June 28, 2020 15:11
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 934f247 into alibaba:master Jul 1, 2020
@sczyh30
Copy link
Member

sczyh30 commented Jul 1, 2020

Thanks!

@sczyh30 sczyh30 removed the to-review PRs to review label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Issue related to configurations of Sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants