Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement Arbitrary for BlobTransactionSidecar properly #680

Closed
mattsse opened this issue May 4, 2024 · 4 comments · Fixed by #708
Closed

[Feature] Implement Arbitrary for BlobTransactionSidecar properly #680

mattsse opened this issue May 4, 2024 · 4 comments · Fixed by #708
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented May 4, 2024

Component

consensus, eips, genesis

Describe the feature you would like

alloy/crates/eips/src/eip4844/sidecar.rs

Line 18 in d78e79e

pub struct BlobTransactionSidecar {

Arbitrary impl should produce:

  • random blobs + matching commitments + proofs

Additional context

No response
@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels May 4, 2024
@mattsse mattsse mentioned this issue May 4, 2024
Merged
@prestwich
Copy link
Member

It would be easy to use the SidecarBuilder to achieve this :)

@leruaa
Copy link
Contributor

leruaa commented May 5, 2024

I can take this on.

@dorlneylon dorlneylon mentioned this issue May 7, 2024
Merged
3 tasks
@leruaa
Copy link
Contributor

leruaa commented May 7, 2024 •
edited
Loading

@prestwich Unfortunately using SidecarBuilder is not possible because it's in alloy-consensus while BlobTransactionSidecar is in alloy-eips, and adding a dep of alloy-consensus in alloy-eips creates a circular dep.

Do you think it makes sense to move SidecarBuilder to alloy-eips?

@prestwich
Copy link
Member

yes i think that would make sense

prestwich pushed a commit that referenced this issue May 21, 2024
@dorlneylon
Arbitrary Sidecar implementation + build. Closes #680. (#708)
251e11e 
* Arbitrary Sidecar implementation + build

* tests fixes

* refactoring the builder

* minor fixes

* tests fixes

* fixes...

* make linter happy

* making clippy happy...

* repository conventions fix + pipeline issue resolved

* a few more pipeline features fixes...

* made a mistake

* finally...

* Reviews

* reviews

* clippy's tests

* clippy
ben186 pushed a commit to ben186/alloy that referenced this issue Jul 27, 2024
@dorlneylon
Arbitrary Sidecar implementation + build. Closes alloy-rs#680. (alloy…
5a5e12a 
…-rs#708)

* Arbitrary Sidecar implementation + build

* tests fixes

* refactoring the builder

* minor fixes

* tests fixes

* fixes...

* make linter happy

* making clippy happy...

* repository conventions fix + pipeline issue resolved

* a few more pipeline features fixes...

* made a mistake

* finally...

* Reviews

* reviews

* clippy's tests

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Arbitrary Sidecar implementation + build. Closes #680. dorlneylon/alloy
3 participants
@leruaa @prestwich @mattsse