chore: convert rcp-types-eth block Header to consensus Header #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddav
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 5, 2024
crates/rpc-types-eth/src/block.rs
Outdated
| @@ -149,6 +149,60 @@ impl Header { | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<Header> for alloy_consensus::Header { | |||
| type Error = String; | |||
There was a problem hiding this comment.
done. i just used a "::Custom" error, since the ConversionError seems to be made for Transactions, i didnt want to add other variants to it
mattsse
approved these changes
Jul 5, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…rs#1014) * chore: convert rcp-types-eth block Header to consensus Header * clippy * custom conversion error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently multiple Block Header types (@mattsse told me it's because of legacy naming).
This PR adds a way to convert one into the other. I needed that in order to then RLP encode the Header. I added tests at the bottom to make sure the RLP encoding is correct and correctly recomputes the block hash