feat: generate valid signed auth signatures #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
Rjected
force-pushed
the
dan/arbitrary-random-signature
branch
from
3241244
to
1672cce
Compare
mattsse
approved these changes
Jul 11, 2024
Comment on lines
+44
to
+45
| # for signed authorization list arbitrary | ||
| k256 = { workspace = true, optional = true } |
There was a problem hiding this comment.
this is fine because if if the feature is enabled on alloy-primitives this dep is already part of the dep tree
| @@ -174,21 +174,21 @@ impl Deref for SignedAuthorization { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(any(test, feature = "arbitrary"))] | |||
| #[cfg(all(any(test, feature = "arbitrary"), feature = "k256"))] | |||
There was a problem hiding this comment.
we could also make this work without the k256 feature but not useful imo
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: generate valid signed auth signatures * feature gate the auth arbitrary
j75689
pushed a commit
to bnb-chain/alloy
that referenced
this pull request
Aug 1, 2024
* feat: generate valid signed auth signatures * feature gate the auth arbitrary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This makes it so the auth list signature is not hard coded, although this gates the arbitrary implementation behind the k256 feature
Solution
Just generate a hash, based on the auth, and sign it
PR Checklist