Feat: eth_simulateV1 Request / Response types #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DoTheBestToGetTheBest
changed the title
mattsse
requested changes
Jul 15, 2024
ty!
ty but i'm not sure to understand wdym by this ? |
mattsse
requested changes
Jul 16, 2024
Blaeaea
reviewed
Jul 18, 2024
Blaeaea
reviewed
Jul 18, 2024
|
@DoTheBestToGetTheBest do you have the bandwidth to finalize this pr? we'd need a few tests that serialize data from the examples |
sorry, it was already done and i though i commited change |
mattsse
approved these changes
Jul 25, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* Feat: eth_simulateV1 Request / Response types * Update lib.rs * Update simulate.rs * fmt * Update simulate.rs * Update simulate.rs * Delete crates/rpc-types-trace/src/simulate.rs * Update lib.rs * Create simulate.rs * Update lib.rs * fmt * fmt * Update lib.rs * Update lib.rs * touchups * fix type --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'am going to first convert this to draft, i need some help on some type, like error one and back & stateDb should i use Revm and foundry backend here or i do have to manually implemnt those ? Thank you
This pr should relate #901