feat(otterscan): add ots slim block and serialze OperationType to int #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvisa
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 12, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
… int" This reverts commit 96df6f4. Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
ots-block-without-txs
branch
from
4ddc7cf
to
80d596d
Compare
mattsse
approved these changes
Jul 12, 2024
| where | ||
| S: Serializer, | ||
| { | ||
| serializer.serialize_u8(*self as u8) |
There was a problem hiding this comment.
so this is actually a number and not a string?
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…alloy-rs#1043) * fix(otterscan): add OtsSlimBlock for BlockDetails Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): use serde_repr to serialize OperationType to int Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): add a new function for BlockDetails Signed-off-by: jsvisa <delweng@gmail.com> * Revert "feat(otterscan): use serde_repr to serialize OperationType to int" This reverts commit 96df6f4. Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): custom implement Serialize for OperationType Signed-off-by: jsvisa <delweng@gmail.com> * (de)serialize to u8 Signed-off-by: jsvisa <delweng@gmail.com> * clippy Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
j75689
pushed a commit
to bnb-chain/alloy
that referenced
this pull request
Aug 1, 2024
…alloy-rs#1043) * fix(otterscan): add OtsSlimBlock for BlockDetails Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): use serde_repr to serialize OperationType to int Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): add a new function for BlockDetails Signed-off-by: jsvisa <delweng@gmail.com> * Revert "feat(otterscan): use serde_repr to serialize OperationType to int" This reverts commit 96df6f4. Signed-off-by: jsvisa <delweng@gmail.com> * feat(otterscan): custom implement Serialize for OperationType Signed-off-by: jsvisa <delweng@gmail.com> * (de)serialize to u8 Signed-off-by: jsvisa <delweng@gmail.com> * clippy Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm running reth along with otterscan, and find some more rpc mismatches:
ots_getInternalOperationsreturnstypeas int, but the default serde json serialize will return as String instead, useserde_reprto serialize it;ots_getBlockDetailswithout transactions, https://github.com/otterscan/otterscan/blob/3adcc62c4eedc56f812fab5ca4b85e3c5fd4b595/docs/custom-jsonrpc.md#L76 https://github.com/ledgerwatch/erigon/blob/6097c05cc914801132e7897427956f196efbbba1/turbo/jsonrpc/otterscan_api.go#L259-L261issuanceandtotal_feesforBlockDetailsAfter this prototypes changed, I think reth can almost run along with otterscan(without the transaction before/after listing and ots2 API)
Solution
PR Checklist