fix: require storageKeys value broken bincode serialization from #955 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtguibas
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 15, 2024
mattsse
changed the title
mattsse
approved these changes
Jul 16, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…y-rs#955 (alloy-rs#1058) * fix: broken bincode serialization from alloy-rs#955 * remove optional in alloy-serde * resolve matt's comments * get rid of broken test * fix cargo fmt * enforce storage key --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
j75689
pushed a commit
to bnb-chain/alloy
that referenced
this pull request
Aug 1, 2024
…y-rs#955 (alloy-rs#1058) * fix: broken bincode serialization from alloy-rs#955 * remove optional in alloy-serde * resolve matt's comments * get rid of broken test * fix cargo fmt * enforce storage key --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bincode serialization issues from #955.
Motivation
Bincode is a common crate used for efficient serialization/deserialization in the Rust ecosystem.
Solution
Removes deserialize_with = "alloy_serde::null_as_default".
PR Checklist