fix(eips): make SignedAuthorizationList arbitrary less fallible #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
approved these changes
Jul 19, 2024
This comment was marked as spam.
This comment was marked as spam.
zerosnacks
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Added stages to the sync info rpc type (#1079) * added stages detail * boxed enum * from hashmap to vec with helper type * serde alias and renames and dos * Update crates/rpc-types-eth/src/syncing.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * Update crates/rpc-types-eth/src/syncing.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * property to pub --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * removing async get account (#1080) * fix(node-bindings): backport fix from ethers-rs (#1081) * feat(consensus): add `From<ConsolidationRequest>` for `Request` (#1083) consensus: add From<ConsolidationRequest> for Request * fix(eips): make SignedAuthorizationList arbitrary less fallible (#1084) * chore: export rpc account type (#1075) * Update debug.rs * Update debug.rs --------- Co-authored-by: Luca Provini <lucaprovini1989@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: StackOverflowExcept1on <109800286+StackOverflowExcept1on@users.noreply.github.com> Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an attempt to fix #1070
Solution
The key generation can be made infallible by instead seeding a rng, and generating a
NonZeroScalarwith it.PR Checklist