Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dep): feature gate jwt in engine types #1131

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore(dep): feature gate jwt in engine types #1131

merged 2 commits into from
Aug 6, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 6, 2024

@mattsse mattsse mentioned this pull request Aug 6, 2024
Merged
DaniPopes
DaniPopes approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can ignore engine and beacon types in the wasm workflow, they are relying on getrand/js feature which was enabled by default through jwt

@mattsse
Copy link
Member Author

mattsse commented Aug 6, 2024

I just forgot to also make rand optional...

@mattsse mattsse merged commit 0c998d3 into main Aug 6, 2024
22 checks passed
@mattsse mattsse deleted the matt/feature-gate-jwt branch August 6, 2024 20:08
grandizzy added a commit to grandizzy/alloy that referenced this pull request Aug 13, 2024
@grandizzy
Revert "chore(dep): feature gate jwt in engine types (alloy-rs#1131)"
e3fb774 
This reverts commit 0c998d3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes