Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types engine default features #1143

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

grandizzy
Copy link
Contributor

Motivation

Include default features of engine types in rpc-types meta crate.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes
Copy link
Member

I think we can do 'default = ["alloy-rpc-types-engine/default"]'?

@@ -34,7 +34,7 @@ serde = { workspace = true, features = ["derive", "std"]}
serde_json.workspace = true

[features]
default = ["eth"]
default = ["eth", "alloy-rpc-types-engine/default"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this pull in the engine types now by default?
should this use the alloy-rpc-types-engine?/default notation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, updated

@mattsse mattsse merged commit dbe6683 into alloy-rs:main Aug 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants