Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc-types-eth): match 7702 in TxReceipt.status() #1149

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix(rpc-types-eth): match 7702 in TxReceipt.status() #1149

merged 1 commit into from
Aug 15, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Aug 15, 2024 •
edited
Loading

Motivation

tx_receipt_7702.status() would always yield false.

Solution

Add ReceiptEnvelope::Eip7702 variant in match

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya changed the title fix(rpc-type-eth): match 7702 in TxReceipt.status() fix(rpc-types-eth): match 7702 in TxReceipt.status() Aug 15, 2024
@mattsse mattsse merged commit f5eaddf into main Aug 15, 2024
26 checks passed
@mattsse mattsse deleted the yash/fix-7702-receipt branch August 15, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-atreya @mattsse