feat: make block struct generic over header type

[mvares]

This PR allows Header to assume a type based on generic.

Closes #1177

[mvares]

hey @emhane, do you know why the CI is failing?

[emhane]

need to make sure that all the implementations for Block will also work for the non-default type. may advice is to add default generics last, after you got everything compiling.

[mvares]

need to make sure that all the implementations for Block will also work for the non-default type. may advice is to add default generics last, after you got everything compiling.

@emhane , I ran all tests and I awaited by compiling. I don't got any error.

[emhane]

sorry wasn't clear enough:

remove the default for the generic.
compile.
fix bugs.
add default generic.

that's how I usually do.

Block::into_full_block is only impl for default header generic now

[mvares]

sorry wasn't clear enough:

remove the default for the generic. compile. fix bugs. add default generic.

that's how I usually do.

Block::into_full_block is only impl for default header generic now

Hmm. Looks a good start.

[mvares]

@emhane, maybe BlockResponse should have a Header generic. What do you think?

[emhane]

@emhane, maybe BlockResponse should have a Header generic. What do you think?

block response does have generic header + transaction in form of associated types

alloy/crates/network-primitives/src/traits.rs

Lines 71 to 74 in dbd9d77

	/// Header type
	type Header;
	/// Transaction type
	type Transaction;

[klkvr]

@emhane wdyt about switching generics order? it would turn this update into a non-breaking change and also seems more convenient as imo users are most likely to change the tx generic