feat(alloy-rpc-types-eth): Optional serde #1276
Conversation
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
There was a problem hiding this comment.
this seems fine, since all tests basically use serde we could derive serde for tests as well, but this would now require changing all attributes, so I'm fine with this.
would appreciate one additional sanity review @klkvr @DaniPopes
There was a problem hiding this comment.
lgtm! wondering if need for this means we are missing something in consensus types?
had a feeling that rpc-types were supposed to always implement serde as they should only be used to communicate with RPC, so curious to learn more about usecases needing this change
|
actually, @refcell is this a size related issue? because this will still pull in serde via alloy-serde I believe |
Good point, it was to decrease size and generally make available lighter types. Wonder if I can place alloy-serde behind the feature flag as well |
|
should be possible to make it optional |
|
actually, let me take a look at the engine type crate |
|
ref #1280 |
refcell
force-pushed
the
rf/feat/optional-serde
branch
from
81508e1
to
0f1b946
Compare
Description
Downstream crates would like to use types from
alloy-rpc-types-ethwithout the need forserdesupport. This PR places serialization for core eth types behind theserdefeature flag that is enabled-by-default.