make factory and paymaster fields optional in PackedUserOperation
#1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dastanbeksamatov
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
requested changes
Sep 23, 2024
There was a problem hiding this comment.
all of these should probably be ignored if missing?
see for ref
alloy/crates/rpc-types-eth/src/pubsub.rs
Line 48 in 21bc07e
makes sense, q about optional fields
dastanbeksamatov
force-pushed
the
fix/user-operation-optional-fields
branch
from
753757e
to
7f33329
Compare
mattsse
approved these changes
Sep 23, 2024
mattsse
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Factory and paymaster related fields don't need to be required, as it forces to pass some default value, i.e
null addressforAddress, 0 for gas limits, etc. which leads to invalid user ops.Solution
make factory and paymaster related fields optional
PR Checklist