feat(signer-local): add keystore-geth-compat feature
#1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapoli23
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
gnapoli23
force-pushed
the
gnapoli/keystore_geth_compat
branch
from
aa09bf1
to
1077da5
Compare
gnapoli23
force-pushed
the
gnapoli/keystore_geth_compat
branch
from
1077da5
to
2e4439b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
keystore-geth-compatfeature forsigner-localcrate, in order to enable the serialization of theaddressfield in the keystore file.Motivation
Close #1376 .
Solution
Add
keystore-geth-compatfeature, which requires thekeystoreone to be enabled, in theCargo.tomlfile.PR Checklist