feat(rpc-types): add optimism module and refactor types
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 22, 2024
|
|
||
| /// Optimism specific transaction fields | ||
| #[derive(Debug, Copy, Default, Clone, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub struct OptimismTransactionFields { |
There was a problem hiding this comment.
@mattsse prob follow-up refactor for op-rpc-types?
There was a problem hiding this comment.
yeah maybe we want them separate, but perhaps not actually worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should have the op types as a separate module. Closes #113
Solution
Add a separate module for op types and their from impls.
PR Checklist