Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split rpc types into trace types and rpc types #96

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat: split rpc types into trace types and rpc types #96

merged 1 commit into from
Jan 4, 2024

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Jan 4, 2024

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@Evalir Evalir merged commit ed5a0e8 into main Jan 4, 2024
17 checks passed
@Evalir Evalir deleted the evalir/add-trace-types branch January 4, 2024 18:35
mattsse
mattsse reviewed Jan 4, 2024
View reviewed changes
crates/trace-rpc-types/Cargo.toml
@@ -0,0 +1,48 @@
[package]
name = "alloy-trace-rpc-types"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be called alloy-rpc-trace-types

and the folder name rpc-trace-types

@Evalir Evalir mentioned this pull request Jan 4, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evalir @mattsse