fix(signer-trezor): fix zero gas price when sending legacy tx with trezor #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuDo1403
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
huyhuynh3103
approved these changes
Jun 26, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…ezor (alloy-rs#977) fix(signer-trezor): fix zero gas price for legacy tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a modification to the way gas prices are handled in the creation of legacy transactions for trezor wallet. The change ensures that the trezor-signer safely handles cases where the gas price might not be explicitly provided in the transaction details.
Solution
Previously, the gas price was statically set to zero. This modification allows the trezor-signer to fetch the current gas price from the transaction and defaults to zero if none is specified.
PR Checklist