Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(7702): bincode compatibility #8

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat(7702): bincode compatibility #8

merged 3 commits into from
Sep 30, 2024

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Sep 30, 2024 •
edited
Loading

Motivation

See alloy-rs/alloy#1349

Solution

eips/crates/eip7702/src/lib.rs

Lines 15 to 21 in ba49e53

/// Bincode-compatible serde implementations for EIP-7702 types.
///
/// `bincode` crate doesn't work with `#[serde(flatten)]` attribute, but some of the EIP-7702 types
/// require flattenning for RPC compatibility. This module makes so that all fields are
/// non-flattenned.
///
/// Read more: <https://github.com/bincode-org/bincode/issues/167#issuecomment-897629039>

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@shekhirin shekhirin added the enhancement New feature or request label Sep 30, 2024
@shekhirin shekhirin changed the title Alexey/bincode compat feat(7702): bincode compatibility Sep 30, 2024
@shekhirin shekhirin marked this pull request as ready for review September 30, 2024 15:46
@mattsse mattsse merged commit efff991 into main Sep 30, 2024
26 checks passed
@mattsse mattsse deleted the alexey/bincode-compat branch September 30, 2024 15:57
@shekhirin shekhirin mentioned this pull request Oct 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse