Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace UnsignedTx and TxEnvelope with op types in Network impl #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace UnsignedTx and TxEnvelope with op types in Network impl #121

wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 24, 2024 •
edited
Loading

Motivation

Bug: deposit tx not covered by alloy transaction envelope and unsigned transaction types in Network impl for Optimism

Solution

Replaces alloy types for Network::TxEnvelope and Network::UnsignedTx with OP types OpTxEnvelope and OpTypedTransaction respectively.

blocked by #27

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr mentioned this pull request Oct 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emhane