Merge pull request #2960 from amitsingh-007/b-fix-bookmark-save

amitsingh-007 · Mar 31, 2024 · 91cc9c8 · 91cc9c8 · github-actions · Mar 31, 2024
2 parents 7bd7e47 + 3c8d9a7
commit 91cc9c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/apps/extension/src/BookmarksPanel/store/useBookmarkStore.ts b/apps/extension/src/BookmarksPanel/store/useBookmarkStore.ts
@@ -153,8 +153,8 @@ const useBookmarkStore = create<State>()((set, get) => ({
   ) => {
     const { contextBookmarks, urlList, folders, addToUpdateTaggedPersons } =
       get();
-    const oldBookmark = contextBookmarks[pos];
-    if (oldBookmark.isDir) {
+    const oldBookmark = contextBookmarks.at(pos); // If undefined, it's a new bookmark
+    if (oldBookmark?.isDir) {
       throw new Error(`Item at pos: ${pos} not a bookmark`);
     }
     const isFolderChange = oldFolder !== newFolder;
@@ -164,7 +164,7 @@ const useBookmarkStore = create<State>()((set, get) => ({
     // Update url in tagged persons
     addToUpdateTaggedPersons(
       urlHash,
-      oldBookmark.taggedPersons,
+      oldBookmark?.taggedPersons ?? [],
       updatedBookmark.taggedPersons
     );
 

diff --git a/packages/configs/manifest/manifest.json b/packages/configs/manifest/manifest.json
@@ -1,6 +1,6 @@
 {
   "key": "fdnekjijeofacghkammknogmiapepano",
-  "version": "20.3.1",
+  "version": "20.3.2",
   "manifest_version": 3,
   "short_name": "Bypass Links",
   "name": "Bypass Links",