SafeFile: do endian-swap on float tag values #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Dec 16, 2023
See: amule-project/amule#342 See: amule-project/amule#368 Bug: https://bugs.gentoo.org/841296 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
There are comments noting that writing raw float values may not be endian-correct and indeed it is not. WX does not provide functions for endian-swapping floats, but since amule explicitly uses exclusively single-precision (32-bit) floats, just cast it into a uint32_t for the swapping. This is a no-op on little-endian.
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Dec 16, 2023
See: amule-project/amule#342 See: amule-project/amule#368 Bug: https://bugs.gentoo.org/841296 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 19, 2023
See: amule-project/amule#342 See: amule-project/amule#368 Bug: https://bugs.gentoo.org/841296 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: #34307 Signed-off-by: Sam James <sam@gentoo.org>
flint2
pushed a commit
to flint2/gentoo
that referenced
this pull request
Dec 19, 2023
See: amule-project/amule#342 See: amule-project/amule#368 Bug: https://bugs.gentoo.org/841296 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: gentoo#34307 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are comments noting that writing raw float values may not be endian-correct and indeed it is not. WX does not provide functions for endian-swapping floats, but since amule explicitly uses exclusively single-precision (32-bit) floats, just cast it into a uint32_t for the swapping.
This is a no-op on little-endian.