Skip to content

Commit

Permalink
test: unlink symlink in ng add base E2E test
Browse files Browse the repository at this point in the history
Instead of attempting to delete all files within the directory, the created
symlink can instead be removed on its own. This should prevent odd Windows
failures in CI.

(cherry picked from commit f05b053)
  • Loading branch information
clydin committed Sep 23, 2024
1 parent 9d0b671 commit 6a52dcc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/legacy-cli/e2e/tests/commands/add/base.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { assetDir } from '../../../utils/assets';
import { expectFileToExist, rimraf, symlinkFile } from '../../../utils/fs';
import { deleteFile, expectFileToExist, symlinkFile } from '../../../utils/fs';
import { ng } from '../../../utils/process';
import { expectToFail } from '../../../utils/utils';

Expand All @@ -15,5 +15,5 @@ export default async function () {
await expectToFail(() => ng('add', 'add-collection')); // File already exists.

// Cleanup the package
await rimraf('node_modules/add-collection');
await deleteFile('node_modules/add-collection');
}

0 comments on commit 6a52dcc

Please sign in to comment.