Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mixing configurations #13370

Closed
wants to merge 1 commit into from
Closed

Support mixing configurations #13370

wants to merge 1 commit into from

Conversation

tomblachut
Copy link

Inspired by #10612 I decided to tackle configuration bloat myself. Noticed that current Architect is being deprecated, but I believe this feature could land before 8.x.

Looking forward to getting feedback, never contributed to OSS before.

@clydin clydin added needs: discussion On the agenda for team meeting to determine next steps area: @angular-devkit/architect labels Jan 5, 2019
@ngbot
Copy link

ngbot bot commented Jan 10, 2019

Hi @tomblachut! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@hansl
Copy link
Contributor

hansl commented Jan 17, 2019

This is a great feature, but unfortunately we are re-working the architect API, so we won't let this in before the rework is done. The good news is that this feature can also be implemented after the rework and we should consider it for 8.0 (or 8.1). We'll let you know when this is ready. Cheers!

Please refer to #13463 for the PR of the new architect API.

@hansl hansl removed the needs: discussion On the agenda for team meeting to determine next steps label Jan 17, 2019
@mgechev
Copy link
Member

mgechev commented Feb 8, 2019

@tomblachut closing this PR since #13463 will change the architect API completely. Let's revisit once #13463 lands!

@mgechev mgechev closed this Feb 8, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants