feat(material/tabs): add alignTabs in MatTabsConfig
#29779
Merged
+134
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naaajii
force-pushed
the
feat/29685
branch
2 times, most recently
from
0021fc8
to
60f2556
Compare
naaajii
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
crisbeto
reviewed
Sep 24, 2024
crisbeto
approved these changes
Sep 25, 2024
crisbeto
added
action: merge
crisbeto
reviewed
Sep 25, 2024
src/material/tabs/tab-group.ts
Outdated
| @@ -147,6 +148,10 @@ export class MatTabGroup implements AfterContentInit, AfterContentChecked, OnDes | |||
| @Input({alias: 'mat-stretch-tabs', transform: booleanAttribute}) | |||
| stretchTabs: boolean = true; | |||
|
|
|||
| /** Alignment for tabs label. */ | |||
| @Input({alias: 'mat-align-tabs'}) | |||
| alignTabs: 'start' | 'center' | 'end' | null = null; | |||
There was a problem hiding this comment.
While this is the correct type, it looks like we'll have to set it to string | null since it breaks some cases internally.
There was a problem hiding this comment.
I updated it but internal cases CI is still pending not sure if recent push triggered it or not.
also this is wrong place to ask but when I run yarn after fork it keeps failing with:
[3/5] Fetching packages...
error Couldn't find match for "36946be4df61f6549ae3829c026022e47674eae2" in "refs/heads/main" for "https://github.com/angular/dev-infra-private-ng-dev-builds.git".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
my-pc@mypc-Latitude-3310:~/Development/angular-projects/open-source/components$
I tried to manually install the package in a clean folder with only @angular/ng-dev package but it still failed I have a global setting for specific NPM packages but they only work with npm (not sure if they will collide with yarn) & also this is something that came up recently, I was able to install packages before IIRC.
naaajii
changed the title
align in MatTabsConfigalignTabs in MatTabsConfig
users can align tabs label via config now rather than adding `mat-tab-align` property on each tab group fixes angular#29685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users can align tabs label via config now rather than adding
mat-tab-alignproperty on each tab groupfixes #29685