fix(material/chips): chip set overwriting disabled state #29795
Merged
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chip set has been set up in a way where it syncs its state to the chips, instead of the other way around which we follow in other components. This means that if its `disabled` state changes later, it can ovewrite the state that the user explicitly set on the chip. These changes make the logic a bit more robust by writing to a different field. Fixes angular#29783.
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
mmalerba
approved these changes
Sep 30, 2024
crisbeto
added a commit
that referenced
this pull request
Sep 30, 2024
The chip set has been set up in a way where it syncs its state to the chips, instead of the other way around which we follow in other components. This means that if its `disabled` state changes later, it can ovewrite the state that the user explicitly set on the chip. These changes make the logic a bit more robust by writing to a different field. Fixes #29783. (cherry picked from commit 86ebb9b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chip set has been set up in a way where it syncs its state to the chips, instead of the other way around which we follow in other components. This means that if its
disabledstate changes later, it can ovewrite the state that the user explicitly set on the chip.These changes make the logic a bit more robust by writing to a different field.
Fixes #29783.