Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename forked packages for publishing on pub #8

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

IgorBabalich
Copy link

@IgorBabalich IgorBabalich commented Jun 7, 2022

Fixes #7, #5.

Renaming forked by AngularDart Community packages to be able publish and use them on pub.dev
Resolving builds and tests. Fix complained test analyzis.
New package names:
angular -> ngdart (the existing ngdart package utility will be renamed to ngdart_cli)
angular_ast -> ngast
angular_compiler -> ngcompiler
angular_forms -> ngforms
angular_router -> ngrouter
angular_test -> ngtest

…ages to be able publish and use them on pub.dev

Resolving builds and tests. Fix complained test analyzis.
New package names:
   angular -> ngdart (the existing ngdart package utility will be renamed to ngdart_cli)
   angular_ast -> ngast
   angular_compiler -> ngcompiler
   angular_forms -> ngforms
   angular_router -> ngrouter
   angular_test -> ngtest
@IgorBabalich IgorBabalich changed the title #7 Renaming forked by AngularDart Community packages to be able publi… #7 Renaming forked by AngularDart Community packages to be able publish and use them on pub.dev Jun 7, 2022
@GZGavinZhao
Copy link

@IgorBabalich CI enabled. Please check the errors and fix them accordingly. I think many of them can be resolved by a top-level dart format.

@GZGavinZhao GZGavinZhao self-requested a review June 9, 2022 02:12
@GZGavinZhao GZGavinZhao self-assigned this Jun 9, 2022
@GZGavinZhao GZGavinZhao mentioned this pull request Jun 9, 2022
17 tasks
@GZGavinZhao GZGavinZhao changed the title #7 Renaming forked by AngularDart Community packages to be able publish and use them on pub.dev Rename forked packages for publishing on pub Jun 9, 2022
@GZGavinZhao GZGavinZhao removed their assignment Jun 9, 2022
@IgorBabalich
Copy link
Author

Fixed formatting.

@GZGavinZhao
Copy link

Looks good to me so far! I will do the last testing (build angular_components against the new ngdart), and after that, we should be good to go.

@GZGavinZhao GZGavinZhao linked an issue Jun 9, 2022 that may be closed by this pull request
Copy link

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename directories (e.g. angular to ngdart, angular_forms to ngforms).

@IgorBabalich
Copy link
Author

Renamed package directories

@GZGavinZhao
Copy link

@IgorBabalich Please regenerate CI config using mono_repo generate: https://pub.dev/packages/mono_repo

@IgorBabalich
Copy link
Author

mono_repo re-generated

@GZGavinZhao
Copy link

Looks good to me. Thanks!

@GZGavinZhao GZGavinZhao merged commit d29315d into angulardart-community:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants