Account application implementation #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4c6565
requested changes
Aug 8, 2024
pkg/service/account/model.go
Outdated
| // Application represents an API Application | ||
| type Application struct { | ||
| ID string `json:"id"` | ||
| AppName string `json:"name"` |
There was a problem hiding this comment.
Property should match the json representation
- AppName string `json:"name"`
+ Name string `json:"name"`
pkg/service/account/model.go
Outdated
| ID string `json:"id"` | ||
| AppName string `json:"name"` | ||
| Description string `json:"description"` | ||
| CreatedDate string `json:"created_at"` |
There was a problem hiding this comment.
Property should match the json representation
- CreatedDate string `json:"created_at"`
+ CreatedAt string `json:"created_at"`
pkg/service/account/model.go
Outdated
| } | ||
|
|
||
| type ApplicationRestriction struct { | ||
| RestrictionType string `json:"ip_restriction_type"` |
There was a problem hiding this comment.
Property should match the json representation
- RestrictionType string `json:"ip_restriction_type"`
+ IPRestrictionType string `json:"ip_restriction_type"`
pkg/service/account/request.go
Outdated
|
|
||
| type CreateApplicationRequest struct { | ||
| Name string `json:"name"` | ||
| AppDescription string `json:"description"` |
There was a problem hiding this comment.
Property should match the json representation
- AppDescription string `json:"description"`
+ Description string `json:"description"`
pkg/service/account/request.go
Outdated
| } | ||
|
|
||
| type SetRestrictionRequest struct { | ||
| RestrictionType string `json:"ip_restriction_type"` |
There was a problem hiding this comment.
Property should match the json representation
- RestrictionType string `json:"ip_restriction_type"`
+ IPRestrictionType string `json:"ip_restriction_type"`| } | ||
|
|
||
| func (s *Service) getApplicationResponseBody(appID string) (*connection.APIResponseBodyData[Application], error) { | ||
| body := &connection.APIResponseBodyData[Application]{} |
There was a problem hiding this comment.
Just a suggestion - there's helpers available in the connection package which will help remove a lot of the boiler plate. See the PSS GetCase method here for an example:
https://github.com/ans-group/sdk-go/blob/master/pkg/service/pss/service_case.go#L32-L38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation and testing for the Account application API endpoint