Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Target Code Should Use Godoc-Style Inline Docs #1374

Open
ereyes01 opened this issue Nov 19, 2016 · 3 comments
Open

Go Target Code Should Use Godoc-Style Inline Docs #1374

ereyes01 opened this issue Nov 19, 2016 · 3 comments

Comments

@ereyes01
Copy link
Contributor

I'm new to ANTLR and I've been having fun all night with the new Go target, thanks for that!

I've been perusing some of the Go source trying to learn the API of the generated Go code, and I noticed that some functions are documented with what appears to be Javadoc style comments. The standard in Go is to use Godoc-style comments, and the Go linter will complain when exported fields / functions do not have a Godoc comment.

Also, having Godocs gives the free benefit of a nice doc webpage that is autogenerated for any go-gettable repository via godoc.org. Here's what the current ANTLR Go code looks like in godoc.org.

All that being said, I understand it's possible that ANTLR has a project-wide policy of thou shalt use Javadoc that supercedes the language's idiom... up to the maintainers I guess.

@parrt
Copy link
Member

parrt commented Nov 19, 2016

godoc would be best for go target. feel like fixing it? ;)

@ereyes01
Copy link
Contributor Author

I'd be happy to switch the existing javadoc-style ones when I get some time soon... However, for the many undocumented exported functions, someone who actually knows what they're doing with ANTLR would probably write better docs than I :-)

@pboyer pboyer mentioned this issue Mar 16, 2017
@jimidle
Copy link
Collaborator

jimidle commented Aug 23, 2022

I will gradually improve this over time.

parrt added a commit that referenced this issue Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants