Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1238 Swift target #1412

Closed
wants to merge 1 commit into from
Closed

Fixes #1238 Swift target #1412

wants to merge 1 commit into from

Conversation

janyou
Copy link
Contributor

@janyou janyou commented Nov 27, 2016

@parrt Suggestion: To make a similar page to collate common issues information may be better.
@antlr/antlr-targets can read and modify it.

Common issues handling information

Issue ID Antlr Target Status Accepted by
-> Java Done xxx
- C# In progress xxx
- Javascript Done xxx
#1238 Python2 Todo
- Python3 Todo
- Go Todo
- C++ Todo
<- Swift Todo
-> Java Done xxx
- C# In progress xxx
- Javascript Done xxx
#994 Python2 Todo
- Python3 Todo
- Go Todo
- C++ Todo
<- Swift Todo

@mike-lischke
Copy link
Member

mike-lischke commented Nov 27, 2016

@janyou I have no idea what this table means. Can you explain please?

Why don't just make your PR reference the original Java implementation and focus only on your target? Others have to create PRs as well, they cannot use yours.

@janyou
Copy link
Contributor Author

janyou commented Nov 27, 2016

Common issues handling information

Issue ID Antlr Target Status Accepted by
#1238 Java Done xxx
#1238 C# In progress xxx
#1238 Javascript Done xxx
#1238 Python2 Todo
#1238 Python3 Todo
#1238 Go Todo
#1238 C++ Todo
#1238 Swift Todo
#994 Java Done xxx
#994 C# In progress xxx
#994 Javascript Done xxx
#994 Python2 Todo
#994 Python3 Todo
#994 Go Todo
#994 C++ Todo
#994 Swift Todo

Purposes:

  1. Avoid duplication of effort
    When a target has more than one maintainer, one of them can accept the fix task and modify the status.

  2. Avoid missing
    The maintainers of each target can get information on common issues from this page.
    Parrt can check it before releasing.

@janyou
Copy link
Contributor Author

janyou commented Nov 29, 2016

the PR is not correct

@janyou janyou closed this Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants