More accurate error messages #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sets, fixed Java.g4 grammar: [+-] -> [+\-]
Tests fixed.
mike-lischke
reviewed
Mar 3, 2017
| @@ -1140,7 +1140,7 @@ SignedInteger | |||
|
|
|||
| fragment | |||
| Sign | |||
| : [+-] | |||
| : [+\-] | |||
There was a problem hiding this comment.
So this is no longer possible without escaping the minus? It worked when the minus was at the end of the set list.
There was a problem hiding this comment.
Yes, not possible. Old syntax was a bit incorrect.
There was a problem hiding this comment.
@KvanTTT Old syntax was pretty common. I expect it to remain valid. It's by far the most common way I include a - in a set.
parrt
reviewed
Mar 3, 2017
| @@ -147,6 +150,29 @@ private static void optimizeSets(Grammar g, ATN atn) { | |||
| // System.out.println("ATN optimizer removed " + removedStates + " states by collapsing sets."); | |||
| } | |||
|
|
|||
| private static String getIntervalSetEscapedString(IntervalSet intervalSet) { | |||
There was a problem hiding this comment.
not sure this belongs in this class. maybe it goes in CharSupport?
There was a problem hiding this comment.
Ok, I'll move it to CharSupport.
|
Much better :) |
|
Pretty easy. |
|
ok, let's do that. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.