Also support Unicode enumerated properties via \p{Foo=Bar} syntax #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good. Thanks!! |
|
Thanks for the über-quick merge! |
|
You have the hard part. all i do is click! I'm hoping we can finish off 4.7 and ship it soon. anything you can think of to do on your end? |
|
Well, the devil is in the details. Once I finish the TR29 grapheme cluster parser and test perf, I'm sure I'll have at least one fix. |
|
cool. ok, it'll probably be a few weeks on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I went to implement Unicode TR29 grapheme cluster parsing, I found I forgot to include enumerated Unicode properties in the code-generated
UnicodeData.java.Since enumerated properties have multiple values (as opposed to the binary properties we supported previously), I used the semi-standard syntax:
\p{PropertyName=PropertyValue}All the existing tests pass and I added a few more for the new syntax.