Fixing Problems after Swift3.1 Release #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 3.1 was released on Mar. 27th.
The language change should be source compatible, but our implementation is using some language feature that's not guaranteed by the public API thus breaking the ANTLR4 Swift runtime build. This PR will fix those issues along with several warnings because of the language release.
The PR #1793 removing StringExtension public modifier is breaking one unit test that uses the "length" method in the old string extension. The second commit will fix this issue by unwrapping the "length" method in the SwiftTest.stg file. We don't want to expose (those pretty generic) extensions inside Swift runtime but need to make sure our generated parsers (in a different module) still works.