Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParseTreePatternMatcher.split in the Swift runtime. #2100

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

ewanmellor
Copy link
Contributor

Fix the parsing inside ParseTreePatternMatcher.split. It was trivially
broken in a number of ways, with bugs that aren't in the Java version
that it was ported from, so it's obviously never been run before.

This adds unit tests for ParseTreePatternMatcher.split, and makes Chunk
implement Equatable, so that it we can compare Chunk instances in the
tests.

Tidy up the description implementations at the same time.

@ewanmellor ewanmellor force-pushed the swift-fix-parsetreepatternmatcher branch from 217ae12 to ba6c054 Compare November 4, 2017 19:48
Fix the parsing inside ParseTreePatternMatcher.split.  It was trivially
broken in a number of ways, with bugs that aren't in the Java version
that it was ported from, so it's obviously never been run before.

This adds unit tests for ParseTreePatternMatcher.split, and makes Chunk
implement Equatable, so that it we can compare Chunk instances in the
tests.

Tidy up the description implementations at the same time.
@ewanmellor ewanmellor force-pushed the swift-fix-parsetreepatternmatcher branch from ba6c054 to fd8fd17 Compare November 8, 2017 01:05
@parrt parrt added this to the 4.7.1 milestone Nov 29, 2017
@parrt parrt merged commit afa2574 into antlr:master Nov 29, 2017
@ewanmellor ewanmellor deleted the swift-fix-parsetreepatternmatcher branch November 30, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants