Add missing -std=c++11 flag when using non-appleclang compiler on macosx #2168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using non-appleclang compiler on macosx, i.e when using upstream (llvm.org) Clang,
does not add -std=c++11 to the list of compile flags when building the Cpp runtime sources causing the build to fail. This happens when I am using any cmake version >= 3.1.
An alternative fix to the one suggested in this PR is to cmake_minimum_required (VERSION 3.0) instead of 2.8. Not sure why exactly, but the setting minimum version to 3.0 fixes the missing c++11 flag problem (i.e. I would not need to explicitly add the flag as done in this PR).