[Python3] return result instead of None in visitor #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this. |
|
Does the same Bug occur in Python 2 as well? |
|
Indeed the same fix needs to be applied.
@jkmar may I ask that you make it part of this PR?
… Le 31 déc. 2017 à 04:58, Terence Parr ***@***.***> a écrit :
Does the same Bug occur in Python 2 as well?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADLYJGvH98MOkNR1P7mIsBABIlug-qTXks5tFqQQgaJpZM4RN1L->.
|
|
@ericvergnaud sure, I've also applied the same fix to Python 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ParseTreeVisitor in the visitChildren method returned None when it shouldn't visit the next child, so if you overrode the shouldVisitNextChild you would also have to override the visitChildren method only to change that return statement.