Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning from MingGW and error from Clang Windows #2232

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Fixed warning from MingGW and error from Clang Windows #2232

merged 4 commits into from
Nov 9, 2018

Conversation

ChaseOxide
Copy link
Contributor

Reasons for changes are in commit messages.

In general, it fixes:

  • In MingGW
    warning: declaration 'class std::exception' does not declare anything
    class ANTLR4CPP_PUBLIC std::exception; // Needed for VS 2015.
    
  • In Clang (I tested with clang-tidy on Windows specifically)
    error: forward declaration of class cannot have a nested name specifier [clang-diagnostic-error]
      class ANTLR4CPP_PUBLIC std::exception; // Needed for VS 2015.
    

Side note: This sort of reverts the commit 19f584d, where the #ifdef flag for the forward declaration was removed.
Another note: Seems like there's more than just std::exception that requires forward declaration.

This commit fixes:
- In MingGW
  warning: declaration 'class std::exception' does not declare anything
- In Clang (I tested with clang-tidy on Windows specifically)
  error: forward declaration of class cannot have a nested name
    specifier [clang-diagnostic-error]
It will prevent clang-cl to output the warning [ignored-attributes].
@parrt
Copy link
Member

parrt commented Nov 8, 2018

We are getting an error here:

E: Unable to locate package g++-5
E: Couldn't find any package by regex 'g++-5'
apt-get.diagnostics
apt-get install failed

Is that a spurious error or a real problem? @mike-lischke

@mike-lischke
Copy link
Member

It's a pretty small patch. If that doesn't go through without warning we can leave it out. I'm surprised anyway, since I did not get such a warning in Visual Studio.

@parrt parrt added this to the 4.7.2 milestone Nov 9, 2018
@parrt
Copy link
Member

parrt commented Nov 9, 2018

It looks to be a typical spurious inability to download a file from CI.

@parrt parrt merged commit 2471d7e into antlr:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants