Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testability and build improvements #2405

Merged
merged 9 commits into from
Nov 16, 2018
Merged

Testability and build improvements #2405

merged 9 commits into from
Nov 16, 2018

Commits on Nov 15, 2018

  1. [Swift] Make ParserATNSimulator.precedenceTransition return a nullabl… 

    …e value.

This was always clearly a possibility, looking at the body of the method.
The newly-enabled performance tests expose this bug (and I don't know how
we've gotten away with it otherwise for so long).

The Java runtime also returns null at this point.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    d275a8c View commit details
    Browse the repository at this point in the history

  2. Fix mvn clean's deleting of the Swift .build directory. 

    Thanks, Maven.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    0f6581e View commit details
    Browse the repository at this point in the history

  3. Write any dumpstream files into the Travis logs. 

    This means that we will see the errors if Surefire is bailing for any
reason.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c2d69af View commit details
    Browse the repository at this point in the history

  4. Exclude intermediate build products from the runtime-testsuite jar. 

    This means that if you build in an unclean source tree, you don't end up with
intermediate classes in the jar.  (This hasn't broken anything that I noticed,
but it bloats the jar and I wanted to make sure it wasn't messing anything up.)

This excludes .build (the Swift runtime's build directory), target (the Java
runtime's build directory) and Swift/*.xcodeproj (which is not in the source tree
but can be created by devs who are using Xcode).
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    3699ea5 View commit details
    Browse the repository at this point in the history

  5. Change the test asserts so that we can see all the values. 

    Change the unit test asserts so that we can see all the values in the
event of a failure.  When debugging an error, it's useful to see both
the stdout and stderr for the failure.  Previously we would only see
one or the other (whichever one failed the assert).

This adds a helper function BaseRuntimeTest.assertCorrectOutput.

This also removes SpecialRuntimeTestAssert, which has not been used for
2 years.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    e54607d View commit details
    Browse the repository at this point in the history

  6. [Swift] Don't catch exceptions inside the test apps. 

    We get much more info if we let the exception rise to the top level.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    4201dd9 View commit details
    Browse the repository at this point in the history

  7. [Swift] Build and test error checking. 

    Change all the subprocess calls in boot.py to check whether they succeeded,
and set the script status appropriately.

In particular, when our unit tests fail, we need the script to exit
with a failure code so that we actually notice on Travis.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    768a0a6 View commit details
    Browse the repository at this point in the history

  8. [.NET] Make the .NET Travis tests use netstandard1.3. 

    Add -f netstandard1.3 to the dotnet build command used on Travis.

This has been necessary since PR antlr#2024, and the build has been silently failing
all this time.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    481f517 View commit details
    Browse the repository at this point in the history

  9. Make all the Travis test scripts exit in the event of error. 

    Test scripts that ignore errors aren't very helpful.
    @ewanmellor
    ewanmellor committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    443a1d2 View commit details
    Browse the repository at this point in the history