Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE #2423

Merged
merged 1 commit into from
Nov 25, 2018
Merged

fix NPE #2423

merged 1 commit into from
Nov 25, 2018

Conversation

ericvergnaud
Copy link
Contributor

fix NPE encountered with a left-recursive grammar such as:
stuff:
stuff1 # Stuff1
| stuff2 # Stuff2
| (stuff1 | stuff2) stuff3
;

Does not happen in Java because null keys are allowed

@parrt parrt added this to the 4.7.2 milestone Nov 25, 2018
@parrt parrt merged commit 8268fdd into antlr:master Nov 25, 2018
@ericvergnaud ericvergnaud deleted the fix-illegal-dict-key branch November 25, 2018 17:09
@sharwell
Copy link
Member

@ericvergnaud can you add a test for this so other runtimes can be validated against the desired behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants