-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3 Runtime: distribute the tests #2971
Conversation
190678f
to
7ee3901
Compare
I just learned that pulling the tests out of the sdist was a recent happening: #2911 Still, Debian would appreciate having the tests in the sdist. |
there are hardly any tests in the python runtime itself |
@ericvergnaud We'd like to confirm that the runtime works when we build the Debian package, and that it the produced Debian package continues to work even if there are changes to our Python 3 package or other dependencies. |
If there are tests of the Python3 runtime available only on the Java side, then I can co-ordinate with the Debian volunteers who maintain https://tracker.debian.org/pkg/antlr4 ; but we would still appreciate making use of any pure-Python dedicated tests that exist for the Python3 runtime. |
7ee3901
to
d7742bf
Compare
@ericvergnaud I've reworked this PR to only include the As a bonus, I've retained the change that includes the Please let me know if this is more acceptable, thanks! |
Thanks! |
Hello,
I'm packaging the Python 3 runtime for Debian. It would be useful to us if the source distribution (on https://pypi.org/project/antlr4-python3-runtime/ or elsewhere) contained the tests.
I've modified it so that the tests are now part of the installed Python module; with this PR users can confirm their installation with
python3 -m unittest antlr4.test
Many thanks,