Fix Swift runtime ANTLRInputStream that can’t read Unicode scalars #3025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
ANTLRInputStream
in Swift runtime is using array ofCharacter
as internal representation to get Unicode code point asInt
to supply it to the lexer. However, SwiftCharacter
is not representing Unicode code point but representing Unicode grapheme, therefore if the originalString
contains characters that build up from multiple Unicode code points such as Family emoji (👨👩👧👦, which is represented in a singleCharacter
in Swift but actuallyU+1F468 U+200D U+1F469 U+200D U+1F467 U+200D U+1F466
),ANTLRInputStream
will not able to get each Unicode code point.Solution
UnicodeScalar
instead.ANTLRInputStream
can read each unicode code point.