Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch utfcpp build #3164

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Patch utfcpp build #3164

merged 2 commits into from
Apr 27, 2021

Conversation

bigerl
Copy link
Contributor

@bigerl bigerl commented Apr 24, 2021

As promised to @mike-lischke , here is the rebase of #3040 :

It is unnecessary that each time the external dependency utfcpp is pulled, its tests are built and run. Also its samples are unnecessarily generated.
I suggest to use the provided cmake to disable this behavior.
You can find the documentation of the cmake options here: https://github.com/nemtrif/utfcpp/blob/v3.1.1/CMakeLists.txt#L10-L12

Let's make this build a little bit more green and not use unnecessary resources.

@mike-lischke
Copy link
Member

Thanks @bigerl.

@parrt This is a small C++ build change and ready to be merged.

@parrt parrt merged commit 6255420 into antlr:master Apr 27, 2021
@parrt parrt added this to the 4.9.3 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants