Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod to go runtime module #3176

Merged
merged 2 commits into from
May 4, 2021
Merged

Add go.mod to go runtime module #3176

merged 2 commits into from
May 4, 2021

Conversation

Joakker
Copy link
Contributor

@Joakker Joakker commented May 4, 2021

Hopefully fixes #3175

@parrt
Copy link
Member

parrt commented May 4, 2021

Weird. still failing: go.mod not found still. Must be in wrong dir? Our test does something weird when running go?

@Joakker
Copy link
Contributor Author

Joakker commented May 4, 2021

I'm inclined to believe it's the CIitself that's the problem, because on circle-ci, the go runtime tests are successful.

I have the suspicion that it's pulling from the github repo instead of the forked copy with the module file. Since go imports by url (import "github.com/antlr/antlr4/runtime/Go/antlr"), and the repo that the url is pointing to doesn't have the module file, it's not gonna find it like that.

So yeah, I think it's the test that is the problem

@parrt
Copy link
Member

parrt commented May 4, 2021

Hmm...ok, so I'll incorporate and retest.

@parrt parrt merged commit 38ddc28 into antlr:master May 4, 2021
@Joakker
Copy link
Contributor Author

Joakker commented May 4, 2021

Ok, I don't know why it keeps failing. We might have to rewrite the test

@Joakker
Copy link
Contributor Author

Joakker commented May 4, 2021

Actually, I think I do. The go proxy (which is used by the go tool to download packages from the internet), is a bit slow to update, especially for pseudo-releases, which would be the case here. That can be attested by the fact that the documentation page still says that it lacks a go.mod file @parrt

@parrt
Copy link
Member

parrt commented May 5, 2021

Ok, it now seems to think we have one: checked Valid go.mod file :) Still seems to be failing though I think

@Joakker
Copy link
Contributor Author

Joakker commented May 5, 2021

At least it's progress :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Go test suite
2 participants