-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExternalAntlr4Cpp: Mitigate build problems with restricted path lengths and zip files #3200
Conversation
Fix building with external zip file (as supplied by project on website)
|
No I believe the string is only used internal to what is patched. |
I'm still confused where this |
I was thinking #3192 or especially #3169 (as it's approved) would be integrated first as they seemed more straightforward but if you want me to add myself here I can do that. |
We can merge the other 2 patches first, no problem. But the issue with |
Sorry, my explanation wound up mistakenly quoted so you probably didn't see it. Here is the plain text: The only place Note that this PR may not be needed anymore. The ultimate problem was with building the utfcpp test suite, which simply went too deep into sub-directories on Windows if built somewhere not very near the root (by path length). Since that suite has changed there may be no further issue. However, it isn't likely to hurt either. If you read this could you take a look at and potentially update issue #3280? I'm willing to do a PR along the lines I describe if the other utfcpp issues can be worked out (it seems to be downloaded, compiled, but not used, at least on Linux, related to |
OK, so what do we want to do with this PR then? Will you make a new PR with the utfcpp changes and close this one? I rather no like to add a PR, just because it doesn't hurt :-) |
Now that utf8cpp is no longer a dependency it's much less likely a build will run into the path length problem. Closing. |
This deals with #3189 and fixes a problem with specifying a zip file of the Cpp runtime from the website (e.g. https://www.antlr.org/download/antlr4-cpp-runtime-4.9.2-source.zip ).
Given that you've turned the utfcpp tests off in a more recent commit there may no longer be critical path length problems, but it may be better to be safe than sorry.
Accept or close this as you will -- I'll answer questions and do fixes as requested.