Upgrade com.ibm.icu:icu4j to latest (69.1) to avoid potential vulnerabilities it brings

[XenoAmess]

Also change the template to suite this upgrade, as this upgrade makes the java class larger than jvm can accept.

[parrt]

Looks like some errors in the Java tests...

[XenoAmess]

Looks like some errors in the Java tests...

@parrt

I don't think the errors are from this pr

will rebase it on latest master and try again.

---

Oops seems I be wrong. I will find why.

[mmuth]

thanks for opening this PR @XenoAmess , we also wait for the merge :)

[parrt]

merged manually

[parrt]

I'm getting an error. Is this new @XenoAmess ?

java.lang.AssertionError: U+1F481 INFORMATION DESK PERSON is an emoji modifier base

	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.antlr.v4.test.tool.TestUnicodeData.testEnumeratedPropertyEquals(TestUnicodeData.java:143)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)

[KvanTTT]

Also, there are other weird errors after merging:

[ERROR] error(174): org\antlr\v4\test\runtime\java\api\perf\graphemes.g4:14:4: string literals and sets cannot be empty: []
[ERROR] C:\projects\antlr4\org\antlr\v4\test\runtime\java\api\perf\graphemes.g4 [14:4]: string literals and sets cannot be empty: []
[ERROR] error(174): org\antlr\v4\test\runtime\java\api\perf\graphemes.g4:14:77: string literals and sets cannot be empty: []
[ERROR] C:\projects\antlr4\org\antlr\v4\test\runtime\java\api\perf\graphemes.g4 [14:77]: string literals and sets cannot be empty: []

[KvanTTT]

It seems like the following graphemes are not supported in the latest version of com.ibm.icu:icu4j:

A: [\p{Grapheme_Cluster_Break=E_Base}];

UnicodeData.getPropertyCodePoints just returns empty set for such a grapheme. That's why errors about empty string literals and sets are correct.

I suggest dropping these graphemes from test data if they became unsafe.

[parrt]

Agreed. it looks like I should simply drop the entire rule and then remove references to EmojiModifierSequence in the other rules like:

EmojiCoreSequence:
    EmojiModifierSequence
  | EmojiCombiningSequence
  | EmojiFlagSequence;

does that sound correct?

[parrt]

Fixed with #3323

[KvanTTT]

Maybe it makes sense to add some sort of error about unsupported graphemes. Because the message string literals and sets cannot be empty: [] is not clear.