[C++] Use faster alternative to dynamic_cast when not testing inherit… #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcking
force-pushed
the
cpp-static-cast
branch
3 times, most recently
from
9c17eb3
to
9697679
Compare
jcking
force-pushed
the
cpp-static-cast
branch
from
9697679
to
dabdfd0
Compare
|
@mike-lischke Another one, likely of many. |
mike-lischke
approved these changes
Oct 26, 2021
|
@parrt This is a C++ only patch. It can be merged for the upcoming release or after that. Either is fine for me. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the generated lexer/parsers use
dynamic_casteverywhere. This is not necessary when casting from a base class to a derived class and not inspecting the result ofdynamic_cast. In those cases we can usestatic_cast. This patch introducesantlrcpp:downCastwhich usesdynamic_castin debug builds andstatic_castin release builds. This should result in faster generated code in release-like builds.