-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make runtime-testsuite tests run in parallel #3423
Conversation
Fix TSAN warnings related to dfa::DFA::s0
[C++] Upstream various performance, build, and best practice fixes
Fix quotation mark error
Update case-insensitive-lexing.md
…sion and use .dll in test projects
…e direct file path to runtime files It has significantly improved performance
…y test run It has significantly improved performance
[C++] Cleanup ATNDeserializer interface
…OT redirection instead of GOPATH
…rmance C#, JavaScript, Go runtime tests performance improvements
[C++] Bump minimum required version to C++17
[Java] Fix complaints from ErrorProne static analysis
79afc6f
to
6ab1195
Compare
Related issue: #3370 |
cc65c15
to
caece10
Compare
caece10
to
40528ef
Compare
@@ -3,7 +3,10 @@ version: 2.1 | |||
jobs: | |||
test_tool_and_runtime_java: | |||
docker: | |||
- image: cimg/openjdk:8.0 | |||
- image: cimg/openjdk:11.0.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend waiting for the merging of that request #3407 There are some troubles with JDK updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we are going to be only java 8 for this next release because there's no way to use java 11 and generate java 8 class files apparently, at least reliably.
This is something to do with the circleci environment compared to running locally. I'll look into this a different time. |
Just a heads up that I think there's an issue with Swift + parallel tests + (possibly) M1 mac. I see an explosion of |
Have you tried to restrict thread count (2, 4)? It might help. |
yep, I tried threadCount=4 and it's still screwed my machine despite having 8 core. |
And single thread mode works fine? |
Yes, there is no problem running Single threaded mode Swift tests. I just completed one run and I'm now testing your release build version. It does seem faster by the way using release mode |
I plan to look into it at some point, it would help to have more recent java for the tool and test rig, whilst sticking to Java 8 for the runtime.
… Le 30 déc. 2021 à 21:34, Terence Parr ***@***.***> a écrit :
@jcking <https://github.com/jcking> i think we can close this draft; i banged my head on a big CI clean up yesterday: #3445 <#3445> Merging shortly.
—
Reply to this email directly, view it on GitHub <#3423 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJGHE4VF4YVUF5FADBDUTS667ANCNFSM5KOSCE6Q>.
You are receiving this because you are subscribed to this thread.
|
It's hardly possible. I've sent Terrence the following StackOverflow answer: https://stackoverflow.com/a/56064482/1046374 Java 8 and Java 11 have different JVM runtime API. |
oh right. forgot about that. We'll have to move in lock step src/trg :( |
That SO thread is about a different challenge i.e. running Java 11 source code on Java 8 JVM. |
We'd have to prevent java 11 code / lib calls in runtime somehow but I'm for it if we can. |
I suggest closing since it completely has been fixed by #3752 |
Yep, Thanks for the work on this @jcking. Looks like the new PR covers this well... Please let me know if there's something else in this PR that we should carve out! |
No description provided.