do not modify String.prototype in js package #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if |
Signed-off-by: Jon Harris <harris.jb@gmail.com>
jharris4
force-pushed
the
no-string-prototype
branch
from
f4099da
to
790d540
Compare
| @@ -4,8 +4,6 @@ | |||
| */ | |||
|
|
|||
| import Token from './Token.js'; | |||
| import './polyfills/codepointat.js'; | |||
There was a problem hiding this comment.
how does removing this relate to the PR ?
There was a problem hiding this comment.
Those polyfills are modifying the String.prototype if you look at the code.
For example here:
I did check that these polyfills are no longer needed, we've come a long way since they were added around 6 years ago! Now those functions that were polyfilled are available everywhere.
https://caniuse.com/mdn-javascript_builtins_string_codepointat
https://caniuse.com/mdn-javascript_builtins_string_fromcodepoint
|
Yes THIRD-PARTY-NOTICES should be removed |
Signed-off-by: Jon Harris <harris.jb@gmail.com>
|
@parrt blessed |
jimidle
pushed a commit
to jimidle/antlr4
that referenced
this pull request
Mar 28, 2023
* do not modify String.prototype in js package Signed-off-by: Jon Harris <harris.jb@gmail.com> * remove notice file that is no longer relevant Signed-off-by: Jon Harris <harris.jb@gmail.com> --------- Signed-off-by: Jon Harris <harris.jb@gmail.com> Signed-off-by: Jim.Idle <jimi@idle.ws>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.